[
https://issues.apache.org/jira/browse/GROOVY-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139288#comment-18139288
] ASF GitHub Bot commented on GROOVY-9273: ---------------------------------------- codecov-commenter commented on PR #3235: URL: https://github.com/apache/groovy/pull/3235#issuecomment-6673159779 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3235?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `98.96194%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.2648%. Comparing base ([`7287f23`](https://app.codecov.io/gh/apache/groovy/commit/7287f239bd8f344cf057f5293155f59f818b3c3b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`327de26`](https://app.codecov.io/gh/apache/groovy/commit/327de26eb79b794b4a4ee92ec773694c2d8c8853?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3235?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | 91.6667% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3235 +/- ## ================================================== + Coverage 74.1684% 74.2648% +0.0963% - Complexity 43798 44036 +238 ================================================== Files 1692 1694 +2 Lines 149747 150323 +576 Branches 28417 28563 +146 ================================================== + Hits 111065 111637 +572 - Misses 28466 28467 +1 - Partials 10216 10219 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3235?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/groovy/ast/ModuleDeclarationNode.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fast%2FModuleDeclarationNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9hc3QvTW9kdWxlRGVjbGFyYXRpb25Ob2RlLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [...che/groovy/classgen/ModuleDeclarationVerifier.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fclassgen%2FModuleDeclarationVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9jbGFzc2dlbi9Nb2R1bGVEZWNsYXJhdGlvblZlcmlmaWVyLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [...n/java/org/codehaus/groovy/ast/AnnotationNode.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FAnnotationNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9Bbm5vdGF0aW9uTm9kZS5qYXZh) | `72.8682% <100.0000%> (+0.2120%)` | :arrow_up: | | [...rg/codehaus/groovy/classgen/AsmClassGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAsmClassGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0FzbUNsYXNzR2VuZXJhdG9yLmphdmE=) | `86.7251% <100.0000%> (+0.7664%)` | :arrow_up: | | [...org/codehaus/groovy/classgen/ExtendedVerifier.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FExtendedVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0V4dGVuZGVkVmVyaWZpZXIuamF2YQ==) | `94.7735% <100.0000%> (+0.0552%)` | :arrow_up: | | [...a/org/codehaus/groovy/control/CompilationUnit.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FCompilationUnit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvQ29tcGlsYXRpb25Vbml0LmphdmE=) | `81.5939% <100.0000%> (+0.1054%)` | :arrow_up: | | [...rg/codehaus/groovy/control/ModuleImportHelper.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FModuleImportHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvTW9kdWxlSW1wb3J0SGVscGVyLmphdmE=) | `85.0000% <ø> (+10.0000%)` | :arrow_up: | | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/3235?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `87.5808% <91.6667%> (+0.1084%)` | :arrow_up: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3235/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Support module descriptor, aka. module-info > ------------------------------------------- > > Key: GROOVY-9273 > URL: https://issues.apache.org/jira/browse/GROOVY-9273 > Project: Groovy > Issue Type: New Feature > Reporter: Daniel Sun > Priority: Major > > > [https://openjdk.java.net/projects/jigsaw/quick-start] > [http://tutorials.jenkov.com/java/modules.html#java-module-basics] > [https://www.oracle.com/corporate/features/understanding-java-9-modules.html] > [https://www.concretepage.com/java/java-9/java-module] -- This message was sent by Atlassian Jira (v10.3.26#10030026)
