daniellansun commented on PR #3068:
URL: https://github.com/apache/groovy/pull/3068#issuecomment-6716178222
@paulk-asert Thank you — that analysis was exactly what we needed. Tip
`17ee5d34` follows your sketch:
- `SharedVariableExpressionRewriter` is now a thin
`ClassCodeExpressionTransformer` + presence check (same four hook points).
- Added the missing `this::tag` case under `@CompileStatic`, plus switch-arm
and classic for-loop cases inside closures.
- Dropped the dead `getText()` / `startsWith("::")` path; implicit
pointers/references stay implicit.
- Javadoc on `THIS_EXPRESSION` / `SUPER_EXPRESSION` now points transform
authors at `varX("this")` / `varX("super")`.
Locally: `Groovy12441` + rewriter unit tests green, and a broader STC/SC
smoke (`groovy.transform.stc.*` + `asm.sc.*`) also green. CI on this tip is
re-running. Appreciate the detailed write-up — it saved a lot of round-trips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
