daniellansun commented on PR #3262: URL: https://github.com/apache/groovy/pull/3262#issuecomment-6768452805
Thanks Paul — the smaller items are now on the tip: 1. Class-level Bindable/Vetoable stubber removal is narrowed to the listener placeholders, in line with the field-level path and the Javadoc. Class-level `@Vetoable` no longer drops `@Bindable`'s property-change placeholders. 2. Placeholder removal is no longer inside `needsPropertyChangeSupport` / `needsVetoableChangeSupport`. Those methods stay side-effect free, and the callers invoke removal explicitly. 3. The literal-to-constant Bindable/Vetoable changes and the `IndexedPropertyASTTransformation` restructuring are in a separate commit from the functional stubber fix. 4. I'll squash to a single commit before merge, and I'll update the JIRA with Affects Version 6.0.0, Fix Versions 6.0.x and 7.0.0, a component, and a note that the immutable indexed-setter case was only shown with the hand-built AST in `IndexedPropertyStubHandoffTest`. Once GROOVY-12730 lands I'll add the `RecordBox`/`BaseBox` class-file assertion alongside the stub check. Agreed on the 6.0.x backport, including the record stub part as you described. I'll also rebase onto current master. Jochen, thanks — agreed with Paul on the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
