[ 
https://issues.apache.org/jira/browse/GROOVY-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143340#comment-18143340
 ] 

ASF GitHub Bot commented on GROOVY-12569:
-----------------------------------------

testlens-app[bot] commented on PR #3098:
URL: https://github.com/apache/groovy/pull/3098#issuecomment-6813156362

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [Lint gate / 
lint](https://github.com/apache/groovy/actions/runs/43145391731/job/130941876090?pr=3098)
   
   🏷️ Commit: 6137d025ffebe37b224c07774ead21f0e8f8c359
   ▶️ Tests:  59 executed
   🟡 Checks: 4/24 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at 
[testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   




> SC: a package-private class of another GroovyClassLoader compilation fails 
> with IllegalAccessError where dynamic code works
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12569
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12569
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static compilation
>    Affects Versions: 6.0.0
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> A class that is not public is accessible only within its run-time package 
> (JVMS 5.4.4), and the JVM checks that wherever an instruction names the 
> class. Dynamic code uses a package-private class of an earlier 
> {{GroovyShell}} parse, or of a library used by a script, without naming it. 
> Statically compiled code names it and fails:
> {code:groovy}
> def shell = new GroovyShell()
> shell.evaluate '''package p
>     @groovy.transform.PackageScope class Hidden implements Runnable {
>         static String sm() { 'sm' }
>         String name
>         String own() { 'own' }
>         void run() { }
>     }
>     true
> '''
> shell.evaluate '''package p
>     @groovy.transform.CompileStatic
>     def test() {
>         def h = new Hidden(name: 'x')
>         h.run()
>         Runnable r = h
>         [Hidden.sm(), h.own(), h.name]
>     }
>     test()
> ''' // each line fails with IllegalAccessError; without @CompileStatic it 
> works
> {code}
> Expected: with the option {{CompilerConfiguration.RUNTIME_PACKAGE_CHECK}} 
> (GROOVY-12568), an instruction that names such a class is reported when the 
> class is generated. A value of the class that no instruction names keeps 
> working. Classes compiled to class files are used directly.
> PR: https://github.com/apache/groovy/pull/3098



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to