[ 
https://issues.apache.org/jira/browse/GROOVY-10498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18144072#comment-18144072
 ] 

ASF GitHub Bot commented on GROOVY-10498:
-----------------------------------------

codecov-commenter commented on PR #3295:
URL: https://github.com/apache/groovy/pull/3295#issuecomment-6839089792

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3295?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 74.4689%. Comparing base 
([`f1c463f`](https://app.codecov.io/gh/apache/groovy/commit/f1c463f950e148172ff078b8025e2270da511066?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`2429b12`](https://app.codecov.io/gh/apache/groovy/commit/2429b12612084c5231b2cc6540a15754c55a6780?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/3295/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/3295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #3295        +/-   ##
   ==================================================
   - Coverage     74.4693%   74.4689%   -0.0003%     
   - Complexity      44843      44846         +3     
   ==================================================
     Files            1702       1702                
     Lines          152009     152007         -2     
     Branches        29127      29126         -1     
   ==================================================
   - Hits           113200     113198         -2     
     Misses          28399      28399                
     Partials        10410      10410                
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/3295?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...roovy/transform/NamedVariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/3295?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FNamedVariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9OYW1lZFZhcmlhbnRBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh)
 | `81.2121% <100.0000%> (+0.3738%)` | :arrow_up: |
   
   ... and [15 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/3295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> NamedVariant: default value overrides supplied value if it's falsy 
> (positional parameter)
> -----------------------------------------------------------------------------------------
>
>                 Key: GROOVY-10498
>                 URL: https://issues.apache.org/jira/browse/GROOVY-10498
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 3.0.10, 4.0.0
>            Reporter: Eric Milles
>            Priority: Major
>              Labels: named-parameters
>
> Consider the following:
> {code:groovy}
> import groovy.transform.*
> @ToString(includeNames=true)
> class Color {
>   int r, g, b
> }
> @NamedVariant
> String m(@NamedDelegate Color color, Number alpha=4.5) {
>   return [color, alpha].join(' ')
> }
> print m(r:1, g:2, b:3, 0.0) // "Color(r:1, g:2, b:3) 4.5"!
> {code}



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to