daniellansun commented on code in PR #3299:
URL: https://github.com/apache/groovy/pull/3299#discussion_r4572564723


##########
src/main/java/groovy/ui/GroovyMain.java:
##########
@@ -238,10 +238,10 @@ private static final class GroovyCommand {
         @Option(names = {"-p"}, description = "Process files line by line and 
print result (see also -n)")
         private boolean lineByLinePrint;
 
-        @Option(names = {"-pa", "--parameters"}, description = "Generate 
metadata for reflection on method parameter names (jdk8+ only)")
+        @Option(names = {"-pa", "--parameters"}, description = "Generate 
metadata for reflection on method parameter names")
         private boolean parameterMetadata;
 
-        @Option(names = {"-pr", "--enable-preview"}, description = "Enable 
preview Java features (jdk12+ only)")
+        @Option(names = {"-pr", "--enable-preview"}, description = "Enable 
preview Java features (Java 12 or later)")

Review Comment:
   Thanks, Paul, good point. Since the baseline is Java 17 now, I have dropped 
the "(Java 12 or later)" note from the `--enable-preview` help in 28e25666, and 
did the same for the Ant `groovyc` task, groovyConsole and groovysh, together 
with the matching documentation pages.



##########
src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java:
##########
@@ -512,10 +512,10 @@ public static class CompilationOptions {
         @Option(names = {"-w", "--warningLevel"}, description = "The amount of 
warnings to print. Set to 0 for none, 1 for likely errors, 2 for possible 
errors, and 3 for as many warnings as possible.", defaultValue = "1")
         private String warningLevel;
 
-        @Option(names = {"-pa", "--parameters"}, description = "Generate 
metadata for reflection on method parameter names (jdk8+ only)")
+        @Option(names = {"-pa", "--parameters"}, description = "Generate 
metadata for reflection on method parameter names")
         private boolean parameterMetadata;
 
-        @Option(names = {"-pr", "--enable-preview"}, description = "Enable 
preview Java features (jdk12+ only) - must be after classpath but before other 
arguments")
+        @Option(names = {"-pr", "--enable-preview"}, description = "Enable 
preview Java features (Java 12 or later) - must be after classpath but before 
other arguments")

Review Comment:
   Thanks, Paul, good point. Since the baseline is Java 17 now, I have dropped 
the "(Java 12 or later)" note from the `--enable-preview` help in 28e25666, and 
did the same for the Ant `groovyc` task, groovyConsole and groovysh, together 
with the matching documentation pages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to