[
https://issues.apache.org/jira/browse/GROOVY-12784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146032#comment-18146032
] ASF GitHub Bot commented on GROOVY-12784: ----------------------------------------- codecov-commenter commented on PR #3309: URL: https://github.com/apache/groovy/pull/3309#issuecomment-6939085930 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3309?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `61.11111%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.5899%. Comparing base ([`88b30dd`](https://app.codecov.io/gh/apache/groovy/commit/88b30ddf6679cfa0e38b416fffd7677d764138ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`47ee89a`](https://app.codecov.io/gh/apache/groovy/commit/47ee89ababe4154c5faa31d1adb36b4cb9098ad5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3309?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/codehaus/groovy/tools/shell/IO.java](https://app.codecov.io/gh/apache/groovy/pull/3309?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fshell%2FIO.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL3NoZWxsL0lPLmphdmE=) | 61.1111% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3309 +/- ## ================================================== + Coverage 74.5879% 74.5899% +0.0020% - Complexity 45361 45365 +4 ================================================== Files 1707 1707 Lines 153183 153187 +4 Branches 29442 29445 +3 ================================================== + Hits 114256 114262 +6 + Misses 28418 28415 -3 - Partials 10509 10510 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3309?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../main/java/org/codehaus/groovy/tools/shell/IO.java](https://app.codecov.io/gh/apache/groovy/pull/3309?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fshell%2FIO.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL3NoZWxsL0lPLmphdmE=) | `49.2754% <61.1111%> (+4.6600%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3309/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > The shell Logger never prints ANSI colors because IO looks for the old Jansi > ---------------------------------------------------------------------------- > > Key: GROOVY-12784 > URL: https://issues.apache.org/jira/browse/GROOVY-12784 > Project: Groovy > Issue Type: Bug > Affects Versions: 6.0.0 > Reporter: Scott Murphy Heiberg > Priority: Major > > {{org.codehaus.groovy.tools.shell.IO}} decides whether to render ANSI by > looking for {{org.fusesource.jansi.AnsiRenderWriter}}. Since GROOVY-8162 > Groovy ships JLine's Jansi ({{org.jline:jansi}}) instead, which has no such > class, so {{IO.ansiSupported}} is always {{false}} and the shell {{Logger}} > (used by groovydoc) never colors its DEBUG, WARN and ERROR prefixes, although > {{Logger}} already renders them with {{org.jline.jansi.Ansi}}. > {{IO}} should detect JLine's Jansi and render through its {{AnsiConsole}}, > for the JVM's own standard output and error only, so output redirected to a > file or a pipe stays plain. The {{jansi.mode}} system property ({{force}} / > {{strip}}) still applies. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
