[
https://issues.apache.org/jira/browse/GROOVY-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146056#comment-18146056
]
ASF GitHub Bot commented on GROOVY-12786:
-----------------------------------------
codecov-commenter commented on PR #3311:
URL: https://github.com/apache/groovy/pull/3311#issuecomment-6939808748
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3311?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `82.35294%` with `3 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 74.5762%. Comparing base
([`88b30dd`](https://app.codecov.io/gh/apache/groovy/commit/88b30ddf6679cfa0e38b416fffd7677d764138ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`90aa1e4`](https://app.codecov.io/gh/apache/groovy/commit/90aa1e48d8ecc05914c8e8375ac8d45acc5af970?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3311?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...org/apache/groovy/groovysh/jline/GroovyEngine.java](https://app.codecov.io/gh/apache/groovy/pull/3311?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovysh%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fgroovysh%2Fjline%2FGroovyEngine.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eXNoL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL2dyb292eS9ncm9vdnlzaC9qbGluZS9Hcm9vdnlFbmdpbmUuamF2YQ==)
| 82.3529% | [1 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3311 +/- ##
==================================================
- Coverage 74.5879% 74.5762% -0.0117%
- Complexity 45361 45366 +5
==================================================
Files 1707 1707
Lines 153183 153199 +16
Branches 29442 29448 +6
==================================================
- Hits 114256 114250 -6
- Misses 28418 28434 +16
- Partials 10509 10515 +6
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3311?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...org/apache/groovy/groovysh/jline/GroovyEngine.java](https://app.codecov.io/gh/apache/groovy/pull/3311?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovysh%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fgroovysh%2Fjline%2FGroovyEngine.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eXNoL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL2dyb292eS9ncm9vdnlzaC9qbGluZS9Hcm9vdnlFbmdpbmUuamF2YQ==)
| `40.9266% <82.3529%> (-0.1657%)` | :arrow_down: |
... and [11 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3311/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> groovysh: Tab after an unknown dotted name walks the whole working directory
> ----------------------------------------------------------------------------
>
> Key: GROOVY-12786
> URL: https://issues.apache.org/jira/browse/GROOVY-12786
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> Tab completion of a dotted name whose receiver is not a known variable or
> class, such as {{foo.}}, {{[1..2].}} or {{import com.}}, freezes groovysh for
> as long as it takes to walk every file below the directory groovysh was
> started in. {{GroovyEngine.Helpers.sourcesForPackage}} looks for {{.groovy}}
> sources of the package with {{Files.walk(Paths.get("."))}} and matches each
> path against the package, so the whole tree is walked even when the name
> cannot be a package.
> Started from a checkout with about 990,000 files, Groovy 6.0.0 takes 22 to 25
> seconds for each such Tab; from an empty directory it takes 0.2 seconds.
> Groovy 6.0.0's groovysh always completes this way; on master the shell
> completer is the fallback when syntax checking is off.
> Only the directory named by the complete segments of the package needs
> walking: a name with a segment that is not a Java identifier, or whose
> directory does not exist, has no sources to find.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)