Dev-iL commented on code in PR #1489:
URL: https://github.com/apache/hamilton/pull/1489#discussion_r2844925448
##########
.github/workflows/hamilton-lsp.yml:
##########
@@ -23,9 +23,6 @@ jobs:
working-directory: dev_tools/language_server
steps:
- uses: actions/checkout@v3
- - name: Check for missing Apache 2 license headers
- run: python3 scripts/check_license_headers.py
- working-directory: ${{ github.workspace }}
Review Comment:
This answers all similar comments:
After the proposed change, license headers are being enforced by pre-commit
hooks. This approach has several benefits:
1. Contributors can tell there's an issue before getting to ci
2. Coverage isn't lost since hooks should run on ci anyway as part of static
checks
3. No need to maintain license enforcement scripts
4. Hooks were more thorough and detected missing licenses that the ci missed
Whereas the main downside is it's somewhat harder to customize if a specific
file requires special treatment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
