jmarshrossney commented on PR #1524: URL: https://github.com/apache/hamilton/pull/1524#issuecomment-4148854301
Hi @skrawcz . Thanks for the quick and helpful feedback! I don't have a strong opinion on the "defensive check". If left up to me I'll leave it in with a note that makes exactly the point you just made. Tbh I'm still getting used to the idea that type annotations are in any way enforceable in a python project! More than happy to spend a little more time on tests. Might take a few days to get round to it though. Cheers! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
