Aias00 commented on code in PR #2736:
URL: https://github.com/apache/hertzbeat/pull/2736#discussion_r1774278757


##########
alerter/src/main/java/org/apache/hertzbeat/alert/service/impl/AlertDefineServiceImpl.java:
##########
@@ -158,6 +164,18 @@ public AlertDefine getMonitorBindAlertAvaDefine(long 
monitorId, String app, Stri
 
     @Override
     public Page<AlertDefine> getAlertDefines(List<Long> defineIds, String 
search, Byte priority, String sort, String order, int pageIndex, int pageSize) {
+        // parse translation content list
+        ObjectMapper objectMapper = new ObjectMapper();
+        List<String> searchList = Collections.emptyList();
+        if (org.apache.commons.lang3.StringUtils.isNotEmpty(search)) {

Review Comment:
   LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to