tomsun28 commented on code in PR #3366:
URL: https://github.com/apache/hertzbeat/pull/3366#discussion_r2094439190
##########
hertzbeat-alerter/src/main/java/org/apache/hertzbeat/alert/notice/impl/FlyBookAlertNotifyHandlerImpl.java:
##########
@@ -202,4 +210,14 @@ private String createLarkMessage(String userId, String
notificationContent, byte
public byte type() {
return 6;
}
+
+ private boolean isValidBaseUrl(String baseUrl) {
+ // Ensure the base URL is a trusted, fixed URL
+ return baseUrl != null &&
baseUrl.startsWith("https://trusted-domain.com/";);
+ }
Review Comment:
flybook url is not trusted-domain, and else,there will be a deployment of
private Feishu, and the URL domain name is not fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
