tomsun28 commented on code in PR #3474:
URL: https://github.com/apache/hertzbeat/pull/3474#discussion_r2154911750
##########
hertzbeat-common/src/main/java/org/apache/hertzbeat/common/entity/job/protocol/MqttProtocol.java:
##########
@@ -32,50 +32,29 @@
@NoArgsConstructor
public class MqttProtocol implements CommonRequestProtocol, Protocol {
- /**
- * ip address or domain name of the peer host
- */
+ private String clientId;
+ private String username;
+ private String password;
private String host;
-
- /**
- * peer host port
- */
private String port;
+ private String protocol;
+ private String timeout;
+ private String keepalive;
+ private String topic;
+ private String testMessage;
+ private String tlsVersion;
+ private String insecureSkipVerify;
+ private String caCert;
+ private String enableMutualAuth;
+ private String clientCert;
+ private String clientKey;
Review Comment:
hi suggest add the code comment as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
