bigcyy commented on PR #3482: URL: https://github.com/apache/hertzbeat/pull/3482#issuecomment-2990034308
Thank you for your PR. I think there are no problems overall. I have carefully reviewed [Logical/set binary operators](https:prometheus.io/docs/prometheus/latest/querying/operators/#logicalset-binary-operators). After comparing the current expression logic, I think we still need to modify `or`, `unless`, and `logical expressions` in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
