Re: [PR] [Improve] optimize the dashboard page and adapt to the new theme [hertzbeat]

Sun, 31 Aug 2025 02:27:40 -0700 


delei commented on PR #3730:
URL: https://github.com/apache/hertzbeat/pull/3730#issuecomment-3239950998

   > hi looks well👍, a small suggestion: could the type distribution be 
displayed on the same line as the type name, removing the colors or using the 
others color which not prominent ? <img alt="image" width="354" height="413" 
src="https://private-user-images.githubusercontent.com/24788200/483947273-19ed0af1-a93f-4ae3-9985-79ea6bec7b2a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY2MzI0ODIsIm5iZiI6MTc1NjYzMjE4MiwicGF0aCI6Ii8yNDc4ODIwMC80ODM5NDcyNzMtMTllZDBhZjEtYTkzZi00YWUzLTk5ODUtNzllYTZiZWM3YjJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODMxVDA5MjMwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzMGFiZGI2ODY3ODkwNjRmZGZmNDMwMTJkMDIwZGU1NWJkNGZiMjU2MWUwZWY1Zjk1NDlmODYzYzVkZjhkZGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QJZkSs7r-aSKS8ksw03uQpFC9aXa
 v29fHUhJ3d4cLs4">
   > 
   > And we also need to consider the color dispaly when in black theme. How 
about for the `collector` ui, we remove the background color. <img alt="image" 
width="539" height="571" 
src="https://private-user-images.githubusercontent.com/24788200/483947529-cf5588fc-261c-40e6-9378-0ba05cf5ed0c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY2MzI0ODIsIm5iZiI6MTc1NjYzMjE4MiwicGF0aCI6Ii8yNDc4ODIwMC80ODM5NDc1MjktY2Y1NTg4ZmMtMjYxYy00MGU2LTkzNzgtMGJhMDVjZjVlZDBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODMxVDA5MjMwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThmZDE1N2IwMjZkYWE2NzkwNjQ5YWM1ODBhMmI2NjkyZGI3MjVkMTNmMWJhZGYyZmZiNGUyMWU4NTEyYzQxNzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Cn_hBZBsnkXkQCyhPrn38GBQmJuY5caC5BobkoTAIXs";>
   
   :ok_hand: ACK, I will modify these two sections ASAP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to