yuluo-yx commented on code in PR #11:
URL:
https://github.com/apache/hertzbeat-collector-go/pull/11#discussion_r2330393652
##########
internal/cmd/server.go:
##########
@@ -109,6 +110,11 @@ func server(ctx context.Context, logOut io.Writer) error {
func startRunners(ctx context.Context, cfg *clrServer.Server) error {
+ // Initialize all collectors before starting runners
Review Comment:
我觉得可以将这部分移动到 job 内部完成 这样项目整体结构会更好理解一些
从 server 启动依赖组件，collector task 也是 job 的一部分？你怎么看 @TJxiaobao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
