yuluo-yx commented on code in PR #14:
URL:
https://github.com/apache/hertzbeat-collector-go/pull/14#discussion_r2333966697
##########
internal/collector/common/job/job_server.go:
##########
@@ -43,23 +45,23 @@ type TimeDispatcher interface {
// Config represents job service configuration
type Config struct {
clrServer.Server
+ TimeDispatch TimeDispatcher
}
// Runner implements the service runner interface
type Runner struct {
Config
- timeDispatch TimeDispatcher
- mu sync.RWMutex
- runningJobs map[int64]*jobtypes.Job
- ctx context.Context
- cancel context.CancelFunc
+ mu sync.RWMutex
+ runningJobs map[int64]*jobtypes.Job
+ ctx context.Context
Review Comment:
这里 context 没有去掉
这些配置应该都在 config 中
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
