Aias00 commented on PR #12: URL: https://github.com/apache/hertzbeat-collector-go/pull/12#issuecomment-3272911206
@yuluo-yx 我已经根据您的所有review feedback进行了修改： ✅ **已解决的问题**： 1. **API模块结构** - 恢复了api/go.mod并配置了正确的replace directive 2. **Go版本兼容性** - 保持toolchain版本为1.24.7以确保兼容性 3. **Context管理** - 从Runner struct中移除了context.CancelFunc，遵循Go最佳实践 4. **魔法值** - 将127.0.0.1:1158等值提取为命名常量 5. **配置冲突** - 创建了UnifiedConfigLoader来统一处理env和file配置 6. **统一配置入口** - 实现了NewFromUnifiedConfig方法 所有的修改都已经commit并push到feat/transport分支。麻烦您重新review一下，看看是否还有其他需要改进的地方。谢谢！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
