pentium100 opened a new pull request, #3804:
URL: https://github.com/apache/hertzbeat/pull/3804

   ## What's changed?
   
   1/ extend timeout setting in DnsSdCollectImpl from 3ms to 3000ms. 3ms is too 
small. 
   2/ when add to sd monitor, set host name to unkonw, so the error after this 
will be muted. 
   3/ in service discovery worker, if port is empty string then get the port 
from monitor's parameters.
   
   ## Checklist
   
   - [X]  I have read the [Contributing 
Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
   - [X]  I have written the necessary doc or comment.
   - [X]  I have added the necessary unit tests and all cases have passed.
   
   ## Add or update API
   
   - [ ] I have added the necessary [e2e 
tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have 
passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to