Duansg commented on PR #3810: URL: https://github.com/apache/hertzbeat/pull/3810#issuecomment-3389812065
@mengnankkkk Sorry I forgot to reply to your question in #3811. When handling this part of the logic, my thought was: Because the start byte does not meet the rules, returning directly would leave residual continuation bytes. However, the unknown replacement character has been added because I modified the `isInvalidLabelValue` method to check for unknown replacement characters. These are validated and interrupted (throwing an exception). While trailing continuation bytes would continue parsing, this is limited to the currently parsed label value. Therefore, no additional complex handling for trailing bytes is added unless future implementation requires correctly parsing the current indicator data—unlike the current unacceptable state. Although I've considered these points, I'm also very interested in hearing your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
