Re: [I] [BUG] instance why use id? [hertzbeat]</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=notifications@hertzbeat.apache.org&q=from:%22via+GitHub%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">via GitHub</span></span></a></span> <span class="date"><a href="/search?l=notifications@hertzbeat.apache.org&q=date:20251107" rel="nofollow">Fri, 07 Nov 2025 06:49:44 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> tomsun28 commented on issue #3765: URL: <a rel="nofollow" href="https://github.com/apache/hertzbeat/issues/3765#issuecomment-3502998627">https://github.com/apache/hertzbeat/issues/3765#issuecomment-3502998627</a></pre><pre> hi, how about this refactor. In `Monitor`, change the `host` into `instance`, the `instance` value is host:port, the `ping` monitor's `instance` value is host. Because the monitor params also has the host value, so we can change `Monitor` host. ![Image](<a rel="nofollow" href="https://github.com/user-attachments/assets/3932d7e2-2fba-4216-8135-1f67f5b2d925">https://github.com/user-attachments/assets/3932d7e2-2fba-4216-8135-1f67f5b2d925</a>) Then change the metadata `instancehost` into `instance`, the value is from the monitor instance. ![Image](<a rel="nofollow" href="https://github.com/user-attachments/assets/e700162d-766e-41e5-91f4-3bb9736117da">https://github.com/user-attachments/assets/e700162d-766e-41e5-91f4-3bb9736117da</a>) The we can save the instance as promethues instance into TSDB like victormetrics or greptimedb. Also we need update the metrics query, from using the monitorId to match value to using the instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For additional commands, e-mail: notifications-h...@hertzbeat.apache.org </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg14045.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd4.html#14059">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="mail2.html#14059">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg14069.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg13464.html">[I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg13571.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg13614.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg13802.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg13885.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14044.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14045.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email tSliceCur"><span class="subject">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14069.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14071.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14073.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14196.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14203.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14210.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14217.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14220.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14297.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat...</a></span> <span class="sender italic">via GitHub</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="Re: [I] [BUG] <title>instance why use id? [hertzbeat]"> <input type="hidden" name="msgid" value="I_kwDOGyeqAs7LNdbF-ff88fed8-62f1-41fb-86a3-58ac08885e6e@gitbox.apache.org"> <input type="hidden" name="relpath" value="notifications@hertzbeat.apache.org/msg14059.html"> <input type="submit" value=" via GitHub "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="notifications@hertzbeat.apache.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search notifications"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/notifications@hertzbeat.apache.org/">notifications - all messages</a></li> <li class="icons-about"><a href="/notifications@hertzbeat.apache.org/info.html">notifications - about the list</a></li> <li class="icons-expand"><a href="/search?l=notifications@hertzbeat.apache.org&q=subject:%22Re%5C%3A+%5C%5BI%5C%5D+%5C%5BBUG%5C%5D+%3Ctitle%3Einstance+why+use+id%5C%3F+%5C%5Bhertzbeat%5C%5D%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg14045.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg14069.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">I_kwDOGyeqAs7LNdbF-ff88fed8-62f1-41fb-86a3-58ac08885e6e@gitbox.apache.org</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9e78e930ea66cf74',t:'MTc3NTM5NTg2Mw=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>