starryCoder opened a new pull request, #3854: URL: https://github.com/apache/hertzbeat/pull/3854
The implementation of sendMetricsDataToStorage was redundant. Both the alert consumer and the storage consumer subscribe to the same metricsDataTopic using different group IDs. ## What's changed? In the current Kafka queue setup, the following consumers are configured to handle metrics data: 1. The Alert Consumer `metricsDataToAlertConsumer` subscribes to the `metricsDataTopic`. 2. The Storage Consumer `metricsDataToStorageConsumer` is configured with a different group.id `metrics-persistent-consumer` and also subscribes to the same `metricsDataTopic`. Due to Kafka's publish-subscribe model, any message sent to `metricsDataTopic` is already consumed by both the Alert and Storage consumer groups. The original implementation of `sendMetricsDataToStorage` was redundant, as it attempted to send the same `MetricsData` to a different storage-specific topic `metricsDataToStorageTopic` so, The `sendMetricsDataToStorage` method is changed to an empty implementation . ## Checklist - [ ] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide) - [ ] I have written the necessary doc or comment. - [ ] I have added the necessary unit tests and all cases have passed. ## Add or update API - [ ] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
