aiai-bot commented on PR #3960:
URL: https://github.com/apache/hertzbeat/pull/3960#issuecomment-3743564887
<!-- code-pr-reviewer -->
**Blockers found** - please address before merging:
- `script/docker-compose/hertzbeat-postgresql-greptimedb/` - Missing
`dbdata/` directory
- Docker compose volumes reference `./dbdata/pgdata` and
`./dbdata/tsdbdata` but the directory doesn't exist in git, causing potential
mount failures
- Fix: Create `dbdata/.gitkeep` or update README with mkdir instructions
- `script/assembly/server/assembly-docker-compose.xml:75-85` - No validation
evidence
- PR lacks verification that `mvn package -Prelease` successfully includes
the greptimedb directory in the tarball
- Please confirm the generated artifact contains all expected files
(docker-compose.yaml, conf/, ext-lib/, README.md)
**Suggested tests** (please verify before/after fix):
- `mvn clean package -Prelease -DskipTests` then `tar -tzf
dist/apache-hertzbeat-*-docker-compose.tar.gz | grep greptimedb`
- Extract tarball and run `docker compose up -d` in
hertzbeat-postgresql-greptimedb to verify deployment works
**Non-blocking**:
- Commit message could clarify this fixes an omission from PR #3859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
