Saramanda9988 commented on issue #3983: URL: https://github.com/apache/hertzbeat/issues/3983#issuecomment-3768136515
@Duansg hi, thanks for your suggestion I agree that we shouldn't make major changes for now. I mainly raised this issue to seek the community's opinion on the best long-term approach. Using dynamic concatenation as a minimal change is fine, but it will require the monitor.name to be passed to the tsdb for querying. Maybe we would need to modify the signature of the method used for querying historical data? <img width="2241" height="564" alt="Image" src="https://github.com/user-attachments/assets/8b883bbc-fec5-444c-b802-7fff44e79e6c"; /> Currently, these methods do not pass the monitor.name since GreptimeDB and VictoriaMetrics don't require it. Is this ok for now? I'm eager to hear the community's thoughts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
