Re: [PR] [feature] add datasource status retrieval and update alert settings UI [hertzbeat]

Tue, 20 Jan 2026 03:33:25 -0800 


zqr10159 commented on PR #3985:
URL: https://github.com/apache/hertzbeat/pull/3985#issuecomment-3772422146

   > @zqr10159 hi, thank you for inviting me to review.
   > 
   > > The current parsing rules for PromQL metrics and labels are as follows: 
`[a-zA-Z_] [a-zA-Z0-9_=～{}[\]".~-]* `
   > 
   > In the Examples section, `cpu_usage{instance='server1'} > 80` should be 
replaced with `cpu_usage{instance="server1"} > 80`
   > 
   > > On the page for adding a new threshold, are the warnings overly 
redundant? The current situation is as follows:
   > 
   > <img alt="Snipaste_2026-01-20_17-07-20" width="806" height="300.1171875" 
src="https://private-user-images.githubusercontent.com/112607719/537989300-d055e794-f0de-423b-94c6-5ab14915999a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg5MDg5OTYsIm5iZiI6MTc2ODkwODY5NiwicGF0aCI6Ii8xMTI2MDc3MTkvNTM3OTg5MzAwLWQwNTVlNzk0LWYwZGUtNDIzYi05NGM2LTVhYjE0OTE1OTk5YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDEyMFQxMTMxMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MGNmZWY2MGU2OTEzNjc3NDAyNmYzZmIxMGFmYmExZTdhODM4NjQ4NjliY2ZkYTY0MjMyNzNhMWIzMjQ2MmU5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.he4VFbzCrDep4Vlm9naXpw_8RqKGQcBO3JITo09wUGY";>
   > Can we adjust the style? Let's change it to something like this: <img 
alt="Snipaste_2026-01-20_19-10-42" width="806" height="323.2890625" 
src="https://private-user-images.githubusercontent.com/112607719/537989545-b9bcaf53-c627-4a70-91a5-88db29a35abc.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg5MDg5OTYsIm5iZiI6MTc2ODkwODY5NiwicGF0aCI6Ii8xMTI2MDc3MTkvNTM3OTg5NTQ1LWI5YmNhZjUzLWM2MjctNGE3MC05MWE1LTg4ZGIyOWEzNWFiYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDEyMFQxMTMxMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNDFiMDAwOTVkNzViODRiZTE0ODczZTU0N2Q4MmU4YmU0YWZjNTk5ZDhiMWQ5NzdiNzIxOGEwNTVmOWFjMjI2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.4NXQilS8XNo1gX7Ip_H0y_LQAqN6EPnK0hPIGfcsxzk";>
   > 
   > I'd like to hear your suggestions.
   
   Sounds good. I see you've made the changes. You can continue working on this 
branch. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to