Saramanda9988 commented on code in PR #3994:
URL: https://github.com/apache/hertzbeat/pull/3994#discussion_r2713040014
##########
web-app/src/app/routes/monitor/monitor-data-chart/monitor-data-chart.component.ts:
##########
@@ -264,7 +266,7 @@ export class MonitorDataChartComponent implements OnInit,
OnDestroy {
// load historical metrics data
this.loading =
`${this.i18nSvc.fanyi('monitor.detail.chart.data-loading')}`;
let metricData$ = this.monitorSvc
- .getMonitorMetricHistoryData(this.instance, this.app, this.metrics,
this.metric, this.timePeriod, isInterval)
+ .getMonitorMetricHistoryData(this.instance, this.monitorName, this.app,
this.metrics, this.metric, this.timePeriod, isInterval)
Review Comment:
Do you mean we should modify the app parameter directly in the fe? Maybe
that would require adjusting greptimedb and vm to align with other tsdbs.
Just concerned this adds complexity to these two storages that we'll support
long-term. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
