zqr10159 opened a new pull request, #4001: URL: https://github.com/apache/hertzbeat/pull/4001
This pull request updates how table names are generated and referenced in the `GreptimeDbDataStorage` class to ensure they are properly namespaced by application, and introduces a minor code cleanup for null checks. **Table name generation and usage improvements:** * The `getTableName` method now takes both `app` and `metrics` as parameters and returns a table name in the format `app_metrics`, ensuring better data separation and organization. All usages of this method have been updated accordingly. [[1]](diffhunk://#diff-dd4a74eadd43a778ba87384c5bbfeecdb72f036f6d3b961f0ac63d7652f7d77cL146-R148) [[2]](diffhunk://#diff-dd4a74eadd43a778ba87384c5bbfeecdb72f036f6d3b961f0ac63d7652f7d77cL223-R226) [[3]](diffhunk://#diff-dd4a74eadd43a778ba87384c5bbfeecdb72f036f6d3b961f0ac63d7652f7d77cL249-R251) [[4]](diffhunk://#diff-dd4a74eadd43a778ba87384c5bbfeecdb72f036f6d3b961f0ac63d7652f7d77cL333-R335) **Code cleanup:** * Replaced manual null check (`time != null`) with `Objects::nonNull` in the `batchDeleteLogs` method for more idiomatic and readable code. **Imports:** * Added import for `java.util.Objects` to support the updated null check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
