AMashenkov commented on a change in pull request #5995: IGNITE-10261 MVCC: 
cache operation may hang during late affinity assignment.
URL: https://github.com/apache/ignite/pull/5995#discussion_r262559666
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtGetSingleFuture.java
 ##########
 @@ -311,7 +313,14 @@ private boolean map(KeyCacheObject key, boolean 
forceKeys) {
 
             // By reserving, we make sure that partition won't be unloaded 
while processed.
             if (part.reserve()) {
-                if (forceKeys || (part.state() == OWNING || part.state() == 
LOST)) {
+                boolean mvccNoOwners = false;
+
+                // Force key request is disabled for MVCC. So if there are no 
partition owners for the given key
+                // we need to set flag forceKeys to true to avoid useless 
remapping to other non-owning partitions.
+                if (cctx.mvccEnabled())
 
 Review comment:
   Should partition state be LOST if it has no owners?
   Is additional flag really needed here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to