ptupitsyn commented on a change in pull request #6356: IGNITE-7101: .NET:
IIgnite.GetVersion
URL: https://github.com/apache/ignite/pull/6356#discussion_r269746819
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Common/IgniteProductVersion.cs
##########
@@ -0,0 +1,197 @@
+using System;
+using Apache.Ignite.Core.Binary;
+
+namespace Apache.Ignite.Core.Common
+{
+ using System.Text;
+ using Apache.Ignite.Core.Impl.Common;
+
+ /// <summary>
+ /// Represents node version.
+ /// </summary>
+ public class IgniteProductVersion : IEquatable<IgniteProductVersion>,
IComparable<IgniteProductVersion>
+ {
+ /** Major version number. */
+ private readonly byte _major;
+
+ /** Minor version number. */
+ private readonly byte _minor;
+
+ /** Maintenance version number. */
+ private readonly byte _maintenance;
+
+ /** Stage of development. */
+ private readonly String _stage;
+
+ /** Revision timestamp. */
+ private readonly long _revTs;
+
+ /** Revision hash. */
+ private readonly byte[] _revHash;
+
+ /// <summary>
+ /// Build a node version from <see cref="IBinaryRawReader"/>
+ /// </summary>
+ /// <param name="reader"><see cref="IBinaryRawReader"/></param>
+ /// <returns>Node version</returns>
+ public static IgniteProductVersion FromBinaryReader(IBinaryRawReader
reader)
Review comment:
Let's make this a constructor too for consistency with other classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
