nizhikov commented on a change in pull request #6916: IGNITE-12213: Sql objects system views. URL: https://github.com/apache/ignite/pull/6916#discussion_r330465882
########## File path: modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java ########## @@ -788,14 +790,45 @@ public void testGetAllColumns() throws Exception { "SYS.TRANSACTIONS.OTHER_NODE_ID.null.2147483647", "SYS.TRANSACTIONS.TOP_VER.null.2147483647", "SYS.TRANSACTIONS.KEYS_COUNT.null.10", - "SYS.TRANSACTIONS.CACHE_IDS.null.2147483647" + "SYS.TRANSACTIONS.CACHE_IDS.null.2147483647", + "SYS.CLIENT_CONNECTIONS.VERSION.null.2147483647", + "SYS.SCHEMAS.NAME.null.2147483647", + "SYS.SCHEMAS.PREDEFINED.null.1", + "SYS.TABLES.CACHE_GROUP_ID.null.10", + "SYS.TABLES.CACHE_GROUP_NAME.null.2147483647", + "SYS.TABLES.CACHE_ID.null.10", + "SYS.TABLES.CACHE_NAME.null.2147483647", + "SYS.TABLES.SCHEMA_NAME.null.2147483647", + "SYS.TABLES.TABLE_NAME.null.2147483647", + "SYS.TABLES.AFFINITY_KEY_COLUMN.null.2147483647", + "SYS.TABLES.KEY_ALIAS.null.2147483647", + "SYS.TABLES.VALUE_ALIAS.null.2147483647", + "SYS.TABLES.KEY_TYPE_NAME.null.2147483647", + "SYS.TABLES.VALUE_TYPE_NAME.null.2147483647", + "SYS.VIEWS.NAME.null.2147483647", + "SYS.VIEWS.DESCRIPTION.null.2147483647", + "SYS.VIEWS.SCHEMA.null.2147483647", + "SYS.TABLE_COLUMNS.AFFINITY_COLUMN.null.1", + "SYS.TABLE_COLUMNS.COLUMN_NAME.null.2147483647", + "SYS.TABLE_COLUMNS.SCALE.null.10", + "SYS.TABLE_COLUMNS.PK.null.1", + "SYS.TABLE_COLUMNS.TYPE.null.2147483647", + "SYS.TABLE_COLUMNS.DEFATULT.null.2147483647", Review comment: Renamed to DEFAULT_VALUE since "default" is java keyword. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services