dgarus commented on a change in pull request #6923: IGNITE-12214: Continuous
query system view.
URL: https://github.com/apache/ignite/pull/6923#discussion_r330538829
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/continuous/GridContinuousProcessor.java
##########
@@ -2056,13 +2098,16 @@ else if (log.isDebugEnabled())
private boolean autoUnsubscribe;
/**
+ * @param nodeId Node id.
* @param prjPred Projection predicate.
* @param hnd Continuous routine handler.
* @param bufSize Buffer size.
* @param interval Interval.
* @param autoUnsubscribe Automatic unsubscribe flag.
*/
- LocalRoutineInfo(@Nullable IgnitePredicate<ClusterNode> prjPred,
+ LocalRoutineInfo(
+ UUID nodeId,
Review comment:
I think there is no reason to make classes (interface) RoutineInfo
, LocalRoutineInfo and RemoteRoutineInfo static.
If LocalRoutineInfo isn't static, you can make the constructor like this:
```
LocalRoutineInfo(
@Nullable IgnitePredicate<ClusterNode> prjPred,
GridContinuousHandler hnd,
int bufSize,
long interval,
boolean autoUnsubscribe)
{
assert hnd != null;
assert bufSize > 0;
assert interval >= 0;
assert ctx != null;
this.nodeId = ctx.localNodeId();
this.prjPred = prjPred;
this.hnd = hnd;
this.bufSize = bufSize;
this.interval = interval;
this.autoUnsubscribe = autoUnsubscribe;
}
```
That approach is required fewer changes and less error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
