andrey-kuznetsov commented on a change in pull request #6904: IGNITE-12220
URL: https://github.com/apache/ignite/pull/6904#discussion_r330672080
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/security/cache/CacheOperationPermissionCheckTest.java
##########
@@ -31,41 +31,58 @@
import org.junit.runners.JUnit4;
import static java.util.Collections.singletonMap;
+import static
org.apache.ignite.plugin.security.SecurityPermission.CACHE_CREATE;
+import static
org.apache.ignite.plugin.security.SecurityPermission.CACHE_DESTROY;
import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_PUT;
import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_READ;
import static
org.apache.ignite.plugin.security.SecurityPermission.CACHE_REMOVE;
+import static
org.apache.ignite.plugin.security.SecurityPermission.JOIN_AS_SERVER;
+import static
org.apache.ignite.plugin.security.SecurityPermission.TASK_EXECUTE;
import static
org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause;
/**
* Test CRUD cache permissions.
*/
@RunWith(JUnit4.class)
public class CacheOperationPermissionCheckTest extends
AbstractCacheOperationPermissionCheckTest {
- /** */
+
+ private final String NEW_CACHE="NEW_CACHE";
+ /**
+ *
+ */
@Test
- public void testServerNode() throws Exception {
- testCrudCachePermissions(false);
+ public void testServerNodeAllowAll() throws Exception {
+ testCrudCachePermissionsAllowAll(false);
}
- /** */
+ /**
+ *
+ */
@Test
- public void testClientNode() throws Exception {
- testCrudCachePermissions(true);
+ public void testClientNodeAllowAll() throws Exception {
+ testCrudCachePermissionsAllowAll(true);
}
/**
* @param isClient True if is client mode.
* @throws Exception If failed.
*/
- private void testCrudCachePermissions(boolean isClient) throws Exception {
+ private void testCrudCachePermissionsAllowAll(boolean isClient) throws
Exception {
Review comment:
No need to rename the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
