Vladsz83 commented on a change in pull request #7358: IGNITE-12614 : Disallow
silent deactivation of cluster to prevent in-mem data loss.
URL: https://github.com/apache/ignite/pull/7358#discussion_r377070501
##########
File path:
modules/core/src/main/java/org/apache/ignite/mxbean/IgniteMXBean.java
##########
@@ -388,11 +388,31 @@
)
public boolean pingNode(String nodeId);
+ /** Activates cluster. */
+ @MXBeanDescription(
Review comment:
@nizhikov , how do you think, can we keep IgniteMXBean as it is now in this
PR? With one new
`clusterState(String state, boolean force)`
Unfortunately, we can't use two different default-methods in the interfaces
IgniteMXBean and Ignite:
` default public void active(boolean active){
active(active, false);
}
and
default public void active(boolean active){
active(active, true);
}`
Jaca compilator forces us to choose one in IgniteKernal:
`class org.apache.ignite.internal.IgniteKernal inherits unrelated defaults
for active(boolean) from types org.apache.ignite.Ignite and
org.apache.ignite.mxbean.IgniteMXBean`
I think this happens because there are no real implementations of default
methods within interfaces. They are just code sample for in-lining to
implementation. So, we have two different implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
