ptupitsyn commented on a change in pull request #7572: IGNITE-12835 Thin
client: compute support
URL: https://github.com/apache/ignite/pull/7572#discussion_r400783325
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/ClientConnectionContext.java
##########
@@ -164,6 +182,9 @@ public ClientListenerProtocolVersion currentVersion() {
String user = null;
String pwd = null;
+ if (ver.compareTo(VER_2_0_0) >= 0)
+ supportedFeatures = BitSet.valueOf(reader.readByteArray());
Review comment:
I think we should introduce feature flags both ways right now:
`ClientFeatureFlags` (sent from client to server) and `ServerFeatureFlags`
(sent from server to client). For now we rely a lot on the protocol version to
understand which feature can be used on the client side, and this is quite
hard. Feature flags will make it straightforward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
