glukos commented on a change in pull request #159: Show tests on TC board that
were stable and have become flaky
URL:
https://github.com/apache/ignite-teamcity-bot/pull/159#discussion_r406252751
##########
File path:
tcbot-engine/src/main/java/org/apache/ignite/tcbot/engine/issue/EventTemplates.java
##########
@@ -53,6 +55,11 @@
FAIL, FAIL}
);
+ public static final EventTemplate stablePassedTest = new EventTemplate(
+ new int[]{OK_OR_FAILURE},
+ new int[]{OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK}
+ );
+
Review comment:
Should we add new event template to public static ArrayList<EventTemplate>
templates; ?
According to the its only usage we shouldn't:
` int buildsToQry =
EventTemplates.templates.stream().mapToInt(EventTemplate::cntEvents).max().getAsInt();
ITcBotUserCreds creds =
Preconditions.checkNotNull(backgroundOpsCreds, "Server should be authorized");
tbProc.getTrackedBranchTestFailures(
brachName,
false,
buildsToQry,
creds,
SyncMode.RELOAD_QUEUED,
false,
null,
null,
DisplayMode.None,
null,
-1, false, false);`
Should we rename field "templates" in this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
