glukos commented on a change in pull request #159: Show tests on TC board that
were stable and have become flaky
URL:
https://github.com/apache/ignite-teamcity-bot/pull/159#discussion_r406261962
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/issue/IssueDetector.java
##########
@@ -469,10 +469,14 @@ private boolean registerTestFailIssues(ITeamcityIgnited
tcIgnited,
if (firstFailedBuildId != null) {
type = IssueType.newFailure;
+
final String flakyComments = runStat.getFlakyComments();
if (!Strings.isNullOrEmpty(flakyComments)) {
- if
(runStat.detectTemplate(EventTemplates.newFailureForFlakyTest) == null) {
+ if (runStat.getFlakyRate() > cfg.flakyRate() &&
Review comment:
The other problem is that literally EVERY flaky test is applicable to this
criteria and will appear on the board.
We have to display flaky test that previously were stable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
