tkalkirill commented on a change in pull request #7613: IGNITE-12821 Add check
size into validate_indexes
URL: https://github.com/apache/ignite/pull/7613#discussion_r407587656
##########
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/visor/verify/ValidateIndexesClosure.java
##########
@@ -206,53 +230,55 @@ private VisorValidateIndexesJobResult call0() {
List<Future<Map<PartitionKey, ValidateIndexesPartitionResult>>>
procPartFutures = new ArrayList<>();
List<Future<Map<String, ValidateIndexesPartitionResult>>>
procIdxFutures = new ArrayList<>();
+ List<T3<CacheGroupContext, GridDhtLocalPartition, Future<CacheSize>>>
cacheSizeFutures = new ArrayList<>();
+ List<T3<GridCacheContext, Index, Future<T2<Throwable, Long>>>>
idxSizeFutures = new ArrayList<>();
+
List<T2<CacheGroupContext, GridDhtLocalPartition>> partArgs = new
ArrayList<>();
List<T2<GridCacheContext, Index>> idxArgs = new ArrayList<>();
totalCacheGrps = grpIds.size();
Map<Integer, IndexIntegrityCheckIssue> integrityCheckResults =
integrityCheckIndexesPartitions(grpIds);
+ GridQueryProcessor qryProcessor = ignite.context().query();
+ IgniteH2Indexing h2Indexing =
(IgniteH2Indexing)qryProcessor.getIndexing();
+
for (Integer grpId : grpIds) {
CacheGroupContext grpCtx =
ignite.context().cache().cacheGroup(grpId);
- if (grpCtx == null || integrityCheckResults.containsKey(grpId))
+ if (isNull(grpCtx) || integrityCheckResults.containsKey(grpId))
Review comment:
I know all about it, but it's my style, besides java will eventually remove
it, there's no overhead in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
