ashapkin commented on a change in pull request #8110:
URL: https://github.com/apache/ignite/pull/8110#discussion_r464110009
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core.Tests/Binary/EnumsTest.cs
##########
@@ -85,6 +86,11 @@ private static void CheckValue<T>(T val, bool isBinaryEnum =
true)
{
Assert.AreEqual(string.Format("{0} [typeId={1},
enumValue={2}, enumValueName={3}]",
typeof(T).FullName, binRes.GetBinaryType().TypeId,
binRes.EnumValue, val), binRes.ToString());
+
+ var expectedEnumNames =
Enum.GetValues(typeof(T)).OfType<T>().Select(x => x.ToString()).ToList();
+ var actualEnumNames =
binRes.GetBinaryType().GetEnumValues().Select(v => v.EnumName).ToList();
Review comment:
Optional: it looks like we need to check this:
Assert.AreSame(binRes.GetBinaryType().GetEnumValues(),
binRes.GetBinaryType().GetEnumValues())
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
