gurustron commented on a change in pull request #8104:
URL: https://github.com/apache/ignite/pull/8104#discussion_r483264652
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionImpl.cs
##########
@@ -396,12 +397,18 @@ internal long Id
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design",
"CA1031:DoNotCatchGeneralExceptionTypes",
+ Justification = "Dispose should not throw.")]
public void Dispose()
{
try
{
Close();
}
+ catch
+ {
+ // No-op. Dispose should not throw.
Review comment:
Fixed
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionRollbackOnlyProxy.cs
##########
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Transactions
+{
+ using System;
+ using System.Diagnostics.CodeAnalysis;
+ using System.Globalization;
+ using System.Threading.Tasks;
+ using Apache.Ignite.Core.Impl.Common;
+ using Apache.Ignite.Core.Transactions;
+
+ /// <summary>
+ /// Cache transaction proxy which supports only implicit rollback
operations and getters.
+ /// <para/>
+ /// Supports next operations:
+ /// <list type="bullet">
+ /// <item><description><see cref="Rollback"/>.</description></item>
+ /// <item><description><see
cref="RollbackAsync"/>.</description></item>
+ /// <item><description><see
cref="IDisposable.Dispose"/>.</description></item>
+ /// <item><description>Get <see cref="NodeId"/>.</description></item>
+ /// <item><description>Get <see
cref="Isolation"/>.</description></item>
+ /// <item><description>Get <see
cref="Concurrency"/>.</description></item>
+ /// <item><description>Get <see cref="Label"/>.</description></item>
+ /// <item><description>Get <see
cref="IsRollbackOnly"/>.</description></item>
+ /// <item><description>Get <see cref="Id"/>.</description></item>
+ /// </list>
+ /// </summary>
+ internal class TransactionRollbackOnlyProxy : ITransaction
+ {
+ /** Transactions facade. */
+ private readonly TransactionsImpl _txs;
+
+ /** Unique transaction view ID. */
+ private readonly long _id;
+
+ /** Is closed. */
+ private volatile bool _isClosed;
+
+ public TransactionRollbackOnlyProxy(
+ TransactionsImpl txs,
+ long id,
+ TransactionConcurrency concurrency,
+ TransactionIsolation isolation,
+ TimeSpan timeout,
+ string label,
+ Guid nodeId)
+ {
+ _txs = txs;
+ _id = id;
+ NodeId = nodeId;
+ Isolation = isolation;
+ Concurrency = concurrency;
+ Timeout = timeout;
+ Label = label;
+ }
+
+ /** <inheritdoc /> */
+ public Guid NodeId { get; private set; }
+
+ /** <inheritdoc /> */
+ public long ThreadId
+ {
+ get { throw GetInvalidOperationException(); }
+ }
+
+ /** <inheritdoc /> */
+ public DateTime StartTime
+ {
+ get { throw GetInvalidOperationException(); }
+ }
+
+ /** <inheritdoc /> */
+ public TransactionIsolation Isolation { get; private set; }
+
+ /** <inheritdoc /> */
+ public TransactionConcurrency Concurrency { get; private set; }
+
+ /** <inheritdoc /> */
+ public TransactionState State
+ {
+ get
+ {
+ lock (this)
+ {
+ ThrowIfClosed();
+
+ return _txs.TxState(this);
+ }
+ }
+ }
+
+ /** <inheritdoc /> */
+ public TimeSpan Timeout { get; private set; }
+
+ /** <inheritdoc /> */
+ public string Label { get; private set; }
+
+ /** <inheritdoc /> */
+ public bool IsRollbackOnly
+ {
+ get { return true; }
+ }
+
+ /** <inheritDoc /> */
+ public bool SetRollbackonly()
+ {
+ throw GetInvalidOperationException();
+ }
+
+ /** <inheritDoc /> */
+ public void Commit()
+ {
+ throw GetInvalidOperationException();
+ }
+
+ /** <inheritDoc /> */
+ public Task CommitAsync()
+ {
+ throw GetInvalidOperationException();
+ }
+
+ /** <inheritDoc /> */
+ public void Rollback()
+ {
+ lock (this)
+ {
+ ThrowIfClosed();
+
+ try
+ {
+ _txs.TxRollback(this);
+ }
+ finally
+ {
+ _isClosed = true;
+ }
+ }
+ }
+
+ /** <inheritDoc /> */
+ public Task RollbackAsync()
+ {
+ lock (this)
+ {
+ ThrowIfClosed();
+
+ return _txs.TxRollbackAsync(this)
+ .ContWith(t =>
+ {
+ try
+ {
+ _txs.TxClose(this);
+ }
+ finally
+ {
+ _isClosed = true;
+ }
+ });
+ }
+ }
+
+ /** <inheritDoc /> */
+ public void AddMeta<TV>(string name, TV val)
+ {
+ throw GetInvalidOperationException();
+ }
+
+ /** <inheritdoc /> */
+ public TV Meta<TV>(string name)
+ {
+ throw GetInvalidOperationException();
+ }
+
+ /** <inheritDoc /> */
+ public TV RemoveMeta<TV>(string name)
+ {
+ throw GetInvalidOperationException();
+ }
+
+ /** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design",
"CA1031:DoNotCatchGeneralExceptionTypes",
+ Justification = "Dispose should not throw.")]
+ public void Dispose()
+ {
+ if (!_isClosed)
+ {
+ try
+ {
+ _txs.TxRemove(this);
+ }
+ catch
+ {
+ // No-op. Dispose should not throw.
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
