dmagda commented on a change in pull request #8207:
URL: https://github.com/apache/ignite/pull/8207#discussion_r485772993
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryEventBuffer.java
##########
@@ -40,13 +41,29 @@
*
*/
public class CacheContinuousQueryEventBuffer {
+ /** @see #IGNITE_CONTINUOUS_QUERY_PENDING_BUFF_SIZE */
+ public static final int DFLT_CONTINUOUS_QUERY_PENDING_BUFF_SIZE = 10_000;
+
+ /** @see #IGNITE_CONTINUOUS_QUERY_SERVER_BUFFER_SIZE */
+ public static final int DFLT_CONTINUOUS_QUERY_SERVER_BUFFER_SIZE = 1000;
+
+ /** */
+ @SystemProperty(value = "Maximum size of buffer for pending events", type
= Long.class,
Review comment:
Please update "The max size of the buffer with pending continuous
queries events."
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryHandler.java
##########
@@ -91,13 +92,32 @@
/** */
private static final long serialVersionUID = 0L;
+ /** @see #IGNITE_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD */
+ public static final int DFLT_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD = 100;
+
+ /** @see #IGNITE_CONTINUOUS_QUERY_LISTENER_MAX_BUFFER_SIZE */
+ public static final int DFLT_CONTINUOUS_QUERY_LISTENER_MAX_BUFFER_SIZE =
10_000;
+
+ /** */
+ @SystemProperty(value = "Size of the buffer of events to send acknowledge
to backup", type = Long.class,
+ defaults = "" + DFLT_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD)
+ public static final String IGNITE_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD =
"IGNITE_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD";
+
+ /** */
+ @SystemProperty(value = "Maximum size of continuous query listener buffer.
" +
Review comment:
The maximum size of the continuous query listener buffer. 10% of events
are dropped once the buffer is full.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java
##########
@@ -122,6 +124,15 @@
* Used when persistence enabled.
*/
public class GridCacheOffheapManager extends IgniteCacheOffheapManagerImpl
implements DbCheckpointListener {
+ /** @see #WAL_MARGIN_FOR_ATOMIC_CACHE_HISTORICAL_REBALANCE */
+ public static final int
DFLT_WAL_MARGIN_FOR_ATOMIC_CACHE_HISTORICAL_REBALANCE = 5;
+
+ @SystemProperty(value = "Margin for WAL iterator, that used for historical
rebalance on atomic cache. " +
+ "It is intended for prevent partition divergence due to reordering in
WAL", type = Long.class,
Review comment:
Let's simplify the sentence 'The WAL iterator margin that is used to
prevent partitions divergence on the historical rebalance of atomic caches."
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryEventBuffer.java
##########
@@ -40,13 +41,29 @@
*
*/
public class CacheContinuousQueryEventBuffer {
+ /** @see #IGNITE_CONTINUOUS_QUERY_PENDING_BUFF_SIZE */
+ public static final int DFLT_CONTINUOUS_QUERY_PENDING_BUFF_SIZE = 10_000;
+
+ /** @see #IGNITE_CONTINUOUS_QUERY_SERVER_BUFFER_SIZE */
+ public static final int DFLT_CONTINUOUS_QUERY_SERVER_BUFFER_SIZE = 1000;
+
+ /** */
+ @SystemProperty(value = "Maximum size of buffer for pending events", type
= Long.class,
+ defaults = "" + DFLT_CONTINUOUS_QUERY_PENDING_BUFF_SIZE)
+ public static final String IGNITE_CONTINUOUS_QUERY_PENDING_BUFF_SIZE =
"IGNITE_CONTINUOUS_QUERY_PENDING_BUFF_SIZE";
+
+ /** */
+ @SystemProperty(value = "Batch buffer size", type = Long.class,
Review comment:
Please update to "Continuous queries batch buffer size"
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java
##########
@@ -34,13 +35,27 @@
* </pre>
*/
public class OffheapReadWriteLock {
+ /** @see #IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT */
+ public static final int DFLT_OFFHEAP_RWLOCK_SPIN_COUNT = 32;
+
+ /** */
+ @SystemProperty(value = "Count spin lock iterations before fallback to
block", type = Long.class,
Review comment:
A number of spin-lock iterations to take before falling back to the
blocking approach.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java
##########
@@ -1913,17 +1927,44 @@ public int cachedPagesCount(int bucket) {
/** Class to store page-list cache onheap. */
public static class PagesCache {
+ /** @see #IGNITE_PAGES_LIST_CACHING_MAX_CACHE_SIZE */
+ public static final int DFLT_PAGES_LIST_CACHING_MAX_CACHE_SIZE = 64;
+
+ /** @see #IGNITE_PAGES_LIST_CACHING_STRIPES_COUNT */
+ public static final int DFLT_PAGES_LIST_CACHING_STRIPES_COUNT = 4;
+
+ /** @see #IGNITE_PAGES_LIST_CACHING_EMPTY_FLUSH_GC_THRESHOLD */
+ public static final int
DFLT_PAGES_LIST_CACHING_EMPTY_FLUSH_GC_THRESHOLD = 10;
+
+ /** */
+ @SystemProperty(value = "Pages cache maximum size", type = Long.class,
+ defaults = "" + DFLT_PAGES_LIST_CACHING_MAX_CACHE_SIZE)
+ public static final String IGNITE_PAGES_LIST_CACHING_MAX_CACHE_SIZE =
"IGNITE_PAGES_LIST_CACHING_MAX_CACHE_SIZE";
+
+ /** */
+ @SystemProperty(value = "Stripes count. Must be power of 2", type =
Long.class,
+ defaults = "" + DFLT_PAGES_LIST_CACHING_STRIPES_COUNT)
+ public static final String IGNITE_PAGES_LIST_CACHING_STRIPES_COUNT =
"IGNITE_PAGES_LIST_CACHING_STRIPES_COUNT";
+
+ /** */
+ @SystemProperty(value = "Threshold of flush calls on empty cache to
allow GC of stripes " +
Review comment:
Let's update it a bit "The threshold of flush calls on empty caches to
allow GC of stripes (the flush is triggered two times per checkpoint)."
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryHandler.java
##########
@@ -91,13 +92,32 @@
/** */
private static final long serialVersionUID = 0L;
+ /** @see #IGNITE_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD */
+ public static final int DFLT_CONTINUOUS_QUERY_BACKUP_ACK_THRESHOLD = 100;
+
+ /** @see #IGNITE_CONTINUOUS_QUERY_LISTENER_MAX_BUFFER_SIZE */
+ public static final int DFLT_CONTINUOUS_QUERY_LISTENER_MAX_BUFFER_SIZE =
10_000;
+
+ /** */
+ @SystemProperty(value = "Size of the buffer of events to send acknowledge
to backup", type = Long.class,
Review comment:
"The size of the buffer with acknowledgment events that are sent to
backup nodes."
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java
##########
@@ -34,13 +35,27 @@
* </pre>
*/
public class OffheapReadWriteLock {
+ /** @see #IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT */
+ public static final int DFLT_OFFHEAP_RWLOCK_SPIN_COUNT = 32;
+
+ /** */
+ @SystemProperty(value = "Count spin lock iterations before fallback to
block", type = Long.class,
+ defaults = "" + DFLT_OFFHEAP_RWLOCK_SPIN_COUNT)
+ public static final String IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT =
"IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT";
+
+ /** */
+ @SystemProperty(value = "OffheapReadWriteLock flag to switch between
signal to writers or signal to writers or " +
Review comment:
"The OffheapReadWriteLock flag that switches between writers and readers
policy."
Not sure if this is accurate, please revise if my understanding of the
capability is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
