Amanda1232 commented on a change in pull request #8380:
URL: https://github.com/apache/ignite/pull/8380#discussion_r517156789
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rule/CorrelatedNestedLoopJoinRule.java
##########
@@ -125,6 +119,42 @@ public CorrelatedNestedLoopJoinConverterRule(int
batchSize) {
RelNode left = convert(rel.getLeft(), leftInTraits);
right = convert(right, rightInTraits);
- return new IgniteCorrelatedNestedLoopJoin(cluster, outTraits, left,
right, rel.getCondition(), correlationIds, joinType);
+ call.transformTo(new IgniteCorrelatedNestedLoopJoin(cluster,
outTraits, left, right, rel.getCondition(), correlationIds, joinType));
+ }
+
+ /** */
+ @SuppressWarnings("ClassNameSameAsAncestorName")
+ public interface Config extends RelRule.Config {
Review comment:
Our static analysis engine detects that your pull request includes a
change that **class name shadows simple name of interface**. According to [best
practice](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#nm-class-names-shouldn-t-shadow-simple-name-of-implemented-interface-nm-same-simple-name-as-interface),
it can be exceptionally confusing, creating many situations where you have to
look at import statements to resolve references, and creating many
opportunities to accidentally define methods that don't override the methods in
their superclasses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
