timoninmaxim commented on a change in pull request #8367: URL: https://github.com/apache/ignite/pull/8367#discussion_r526058327
########## File path: modules/core/src/test/java/org/apache/ignite/testsuites/CoreIgniteSpringTestSuite.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.testsuites; + +import org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtMultiBackupTest; +import org.apache.ignite.startup.cmdline.GridCommandLineLoaderTest; +import org.junit.runner.RunWith; +import org.junit.runners.Suite; + +/** + * Spring tests. + */ +@RunWith(Suite.class) [email protected]({ + GridCommandLineLoaderTest.class, + + GridCacheDhtMultiBackupTest.class +}) +public class CoreIgniteSpringTestSuite { Review comment: There is an issue. Those tests are not lost. But they are implemented in core module, but suite is in spring module. The check I've developed can't understand it. So this is a reason. Then I create suites with Core prefix, and put tests to them, then replaced tests in a suite in spring module with link to the new CoreSuite. I don't know what is a right way to do with such tests. But moving them to the LostAndFound suite is incorrect way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
