alamar commented on a change in pull request #8367:
URL: https://github.com/apache/ignite/pull/8367#discussion_r530377703
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/expiry/IgniteCacheAtomicLocalOnheapExpiryPolicyTest.java
##########
@@ -18,6 +18,9 @@
package org.apache.ignite.internal.processors.cache.expiry;
+import org.junit.Ignore;
+
+@Ignore("https://issues.apache.org/jira/browse/IGNITE-9214";)
Review comment:
Class needs javadoc, also below
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/binary/distributed/dht/GridCacheBinaryObjectsAtomicNearDisabledOnheapSelfTest.java
##########
@@ -17,6 +17,9 @@
package org.apache.ignite.internal.processors.cache.binary.distributed.dht;
+import org.junit.Ignore;
+
+@Ignore("https://issues.apache.org/jira/browse/IGNITE-9214";)
Review comment:
This class also needs javadoc (also see several classes below)
##########
File path:
modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/SerializerSuite.java
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.tests;
+
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+@RunWith(Suite.class)
Review comment:
This is a new class, it requires javadoc comment as per coding guidelines
##########
File path:
modules/core/src/test/java/org/apache/ignite/suites/CoreIgniteBinaryCacheQueryTestSuite.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.suites;
+
+import org.apache.ignite.internal.metric.SystemViewSelfTest;
+import
org.apache.ignite.internal.processors.cache.GridCacheQueryIndexingDisabledSelfTest;
+import
org.apache.ignite.internal.processors.cache.GridCacheQueryInternalKeysSelfTest;
+import
org.apache.ignite.internal.processors.cache.GridCacheQuerySqlFieldInlineSizeSelfTest;
+import
org.apache.ignite.internal.processors.cache.IgniteCacheBinaryObjectsScanSelfTest;
+import
org.apache.ignite.internal.processors.cache.IgniteCacheBinaryObjectsScanWithEventsSelfTest;
+import
org.apache.ignite.internal.processors.cache.query.CacheDataPageScanQueryTest;
+import
org.apache.ignite.internal.processors.cache.query.CacheScanQueryFailoverTest;
+import
org.apache.ignite.internal.processors.cache.query.GridCacheQueryTransformerSelfTest;
+import org.apache.ignite.internal.processors.cache.query.GridCircularQueueTest;
+import
org.apache.ignite.internal.processors.cache.query.IgniteCacheQueryCacheDestroySelfTest;
+import
org.apache.ignite.internal.processors.cache.query.IndexingSpiQuerySelfTest;
+import
org.apache.ignite.internal.processors.cache.query.IndexingSpiQueryTxSelfTest;
+import
org.apache.ignite.internal.processors.cache.query.IndexingSpiQueryWithH2IndexingSelfTest;
+import org.apache.ignite.internal.sql.SqlParserBulkLoadSelfTest;
+import org.apache.ignite.internal.sql.SqlParserCreateIndexSelfTest;
+import org.apache.ignite.internal.sql.SqlParserDropIndexSelfTest;
+import org.apache.ignite.internal.sql.SqlParserKillQuerySelfTest;
+import org.apache.ignite.internal.sql.SqlParserMultiStatementSelfTest;
+import org.apache.ignite.internal.sql.SqlParserSetStreamingSelfTest;
+import org.apache.ignite.internal.sql.SqlParserTransactionalKeywordsSelfTest;
+import org.apache.ignite.internal.sql.SqlParserUserSelfTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Test suite for cache queries.
+ */
+@RunWith(Suite.class)
[email protected]({
+ SqlParserCreateIndexSelfTest.class,
+ SqlParserDropIndexSelfTest.class,
+ SqlParserTransactionalKeywordsSelfTest.class,
+ SqlParserBulkLoadSelfTest.class,
+ SqlParserSetStreamingSelfTest.class,
+ SqlParserKillQuerySelfTest.class,
+ SqlParserMultiStatementSelfTest.class,
+
+ GridCacheQueryInternalKeysSelfTest.class,
+ GridCacheQueryTransformerSelfTest.class,
+ CacheScanQueryFailoverTest.class,
+ CacheDataPageScanQueryTest.class,
+ IndexingSpiQuerySelfTest.class,
+ IndexingSpiQueryTxSelfTest.class,
+
+ GridCircularQueueTest.class,
+ IndexingSpiQueryWithH2IndexingSelfTest.class,
+
+ GridCacheQueryIndexingDisabledSelfTest.class,
+ IgniteCacheQueryCacheDestroySelfTest.class,
+ GridCacheQuerySqlFieldInlineSizeSelfTest.class,
+ SqlParserUserSelfTest.class,
+ IgniteCacheBinaryObjectsScanSelfTest.class,
+ IgniteCacheBinaryObjectsScanWithEventsSelfTest.class,
+ SystemViewSelfTest.class
+})
+public class CoreIgniteBinaryCacheQueryTestSuite {
Review comment:
Why not add to IgniteBinaryCacheQueryTestSuite
##########
File path:
modules/core/src/test/java/org/apache/ignite/client/CoreClientTestSuite.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import org.apache.ignite.internal.IgniteClientFailuresTest;
+import org.apache.ignite.internal.client.thin.CacheAsyncTest;
+import org.apache.ignite.internal.client.thin.ClusterApiTest;
+import org.apache.ignite.internal.client.thin.ClusterGroupTest;
+import org.apache.ignite.internal.client.thin.ComputeTaskTest;
+import org.apache.ignite.internal.client.thin.ReliableChannelTest;
+import org.apache.ignite.internal.client.thin.ServicesTest;
+import
org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessDiscoveryTest;
+import
org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessResourceReleaseTest;
+import
org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessStableTopologyTest;
+import
org.apache.ignite.internal.client.thin.ThinClientPartitionAwarenessUnstableTopologyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Tests for Java thin client.
+ */
+@RunWith(Suite.class)
[email protected]({
+ ClientConfigurationTest.class,
+ ClientCacheConfigurationTest.class,
+ FunctionalTest.class,
+ IgniteBinaryTest.class,
+ LoadTest.class,
+ ReliabilityTest.class,
+ ReliabilityTestAsync.class,
+ ReliabilityTestPartitionAware.class,
+ ReliabilityTestPartitionAwareAsync.class,
+ SslParametersTest.class,
+ ConnectionTest.class,
+ ConnectToStartingNodeTest.class,
+ AsyncChannelTest.class,
+ ComputeTaskTest.class,
+ ClusterApiTest.class,
+ ClusterGroupTest.class,
+ ServicesTest.class,
+ ThinClientPartitionAwarenessStableTopologyTest.class,
+ ThinClientPartitionAwarenessUnstableTopologyTest.class,
+ ThinClientPartitionAwarenessResourceReleaseTest.class,
+ ThinClientPartitionAwarenessDiscoveryTest.class,
+ CacheAsyncTest.class,
+ ReliableChannelTest.class,
+ IgniteClientFailuresTest.class
+})
+public class CoreClientTestSuite {
Review comment:
Why not add them to e.g. IgniteClientTestSuite?
##########
File path:
modules/core/src/test/java/org/apache/ignite/suites/CoreIgnitePdsWithIndexingCoreTestSuite.java
##########
@@ -0,0 +1,95 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+package org.apache.ignite.suites;
+
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsAtomicCacheHistoricalRebalancingTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsAtomicCacheRebalancingTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsBinaryMetadataAsyncWritingTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsBinaryMetadataOnClusterRestartTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsBinarySortObjectFieldsTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCorruptedIndexTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsMarshallerMappingRestoreOnNodeStartTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsTxCacheRebalancingTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePdsTxHistoricalRebalancingTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePersistenceSequentialCheckpointTest;
+import
org.apache.ignite.internal.processors.cache.persistence.IgnitePersistentStoreCacheGroupsTest;
+import
org.apache.ignite.internal.processors.cache.persistence.PersistenceDirectoryWarningLoggingTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.IgniteLogicalRecoveryTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.IgnitePdsMultiNodePutGetRestartTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.IgnitePdsPageEvictionTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.IgniteSequentialNodeCrashRecoveryTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsCacheDestroyDuringCheckpointTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsCacheIntegrationTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsDiskErrorsRecoveringTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsNoActualWalHistoryTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.file.IgnitePdsThreadInterruptionTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalRebalanceTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalRecoveryPPCTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.WalOnNodeStartTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.WalPathsTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRecoveryTxLogicalRecordsTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRolloverRecordLoggingFsyncTest;
+import
org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRolloverRecordLoggingLogOnlyTest;
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+
+/**
+ * Test suite for tests that cover core PDS features and depend on indexing
module.
+ */
+@RunWith(Suite.class)
[email protected]({
+ IgnitePdsCacheIntegrationTest.class,
+ IgnitePdsPageEvictionTest.class,
+ IgnitePdsMultiNodePutGetRestartTest.class,
+ IgnitePersistentStoreCacheGroupsTest.class,
+ IgnitePersistenceSequentialCheckpointTest.class,
+ PersistenceDirectoryWarningLoggingTest.class,
+ WalPathsTest.class,
+ WalRecoveryTxLogicalRecordsTest.class,
+ WalRolloverRecordLoggingFsyncTest.class,
+ WalRolloverRecordLoggingLogOnlyTest.class,
+ WalOnNodeStartTest.class,
+
+ IgnitePdsNoActualWalHistoryTest.class,
+ IgniteWalRebalanceTest.class,
+
+ IgnitePdsAtomicCacheRebalancingTest.class,
+ IgnitePdsAtomicCacheHistoricalRebalancingTest.class,
+
+ IgnitePdsTxCacheRebalancingTest.class,
+ IgnitePdsTxHistoricalRebalancingTest.class,
+
+ IgniteWalRecoveryPPCTest.class,
+
+ IgnitePdsDiskErrorsRecoveringTest.class,
+
+ IgnitePdsCacheDestroyDuringCheckpointTest.class,
+
+ IgnitePdsBinaryMetadataOnClusterRestartTest.class,
+ IgnitePdsBinaryMetadataAsyncWritingTest.class,
+ IgnitePdsMarshallerMappingRestoreOnNodeStartTest.class,
+ IgnitePdsThreadInterruptionTest.class,
+ IgnitePdsBinarySortObjectFieldsTest.class,
+
+ IgnitePdsCorruptedIndexTest.class,
+
+ IgniteLogicalRecoveryTest.class,
+
+ IgniteSequentialNodeCrashRecoveryTest.class
+})
+public class CoreIgnitePdsWithIndexingCoreTestSuite {
Review comment:
Let's postpone this great suite renaming. It's even more confusing now
than it was before.
##########
File path:
modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite3.java
##########
@@ -48,34 +26,7 @@
*/
@RunWith(Suite.class)
@Suite.SuiteClasses({
- CacheContinuousQueryBufferLimitTest.class,
-
- GridCacheContinuousQueryNodesFilteringTest.class,
- GridCacheContinuousQueryPartitionTxOneNodeTest.class,
- CacheContinuousWithTransformerReplicatedSelfTest.class,
- CacheContinuousWithTransformerClientSelfTest.class,
- CacheContinuousQueryExecuteInPrimaryTest.class,
- IgniteCacheContinuousQueryNoUnsubscribeTest.class,
-
- ClientReconnectContinuousQueryTest.class,
- IgniteCacheContinuousQueryReconnectTest.class,
- IgniteCacheContinuousQueryClientTxReconnectTest.class,
- IgniteCacheContinuousQueryClientReconnectTest.class,
-
- GridCacheContinuousQueryAtomicSelfTest.class,
- GridCacheContinuousQueryAtomicNearEnabledSelfTest.class,
- GridCacheContinuousQueryPartitionedSelfTest.class,
- GridCacheContinuousQueryReplicatedSelfTest.class,
-
- CacheContinuousQueryFactoryAsyncFilterRandomOperationTest.class,
- CacheContinuousBatchForceServerModeAckTest.class,
- ContinuousQueryReassignmentTest.class,
- CacheContinuousQueryConcurrentPartitionUpdateTest.class,
-
- CacheContinuousQueryCounterPartitionedAtomicTest.class,
- CacheContinuousQueryCounterPartitionedTxTest.class,
- CacheContinuousQueryCounterReplicatedAtomicTest.class,
- CacheContinuousQueryCounterReplicatedTxTest.class
+ CoreIgniteCacheQuerySelfTestSuite3.class
Review comment:
Unanswered
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
