ptupitsyn commented on a change in pull request #2: URL: https://github.com/apache/ignite-python-thin-client/pull/2#discussion_r561680867
########## File path: tests/test_affinity_request_routing.py ########## @@ -0,0 +1,178 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. Review comment: Changing the implementation in order to test it is called "test-induced design damage". With the current approach we can refactor the implementation entirely - the test will not require any changes. > slow How slow? Did you measure it? > buggy This testing approach is used by other thin clients as well, not a single bug in more than a year. > ugly Please elaborate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
