vveider commented on a change in pull request #46:
URL: https://github.com/apache/ignite-3/pull/46#discussion_r569517565
##########
File path: parent/pom.xml
##########
@@ -242,6 +244,14 @@
</dependencies>
</dependencyManagement>
+ <dependencies>
Review comment:
Parent should not have any dependencies except dependencyManagement
section, because it holds only settings, which will be used in maven modules
where dependencies should be declared.
##########
File path: parent/pom.xml
##########
@@ -83,7 +83,9 @@
<maven.deploy.plugin.version>2.8.2</maven.deploy.plugin.version>
<maven.pmd.plugin.version>3.14.0</maven.pmd.plugin.version>
<maven.source.plugin.version>3.2.1</maven.source.plugin.version>
- <maven.surefire.plugin.version>3.0.0-M4</maven.surefire.plugin.version>
+ <maven.surefire.plugin.version>3.0.0-M5</maven.surefire.plugin.version>
+ <maven.failsafe.plugin.version>3.0.0-M5</maven.failsafe.plugin.version>
+
<maven.build-helper.plugin.version>3.1.0</maven.build-helper.plugin.version>
Review comment:
Please, sort params in ABC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
