sergey-chugunov-1985 commented on a change in pull request #8834:
URL: https://github.com/apache/ignite/pull/8834#discussion_r585543045
##########
File path:
modules/dev-utils/src/main/java/org/apache/ignite/development/utils/IgniteWalConverter.java
##########
@@ -94,7 +107,7 @@ public static void convert(final PrintStream out, final
IgniteWalConverterArgume
boolean printAlways = F.isEmpty(params.getRecordTypes());
- try (WALIterator stIt = factory.iterator(iteratorParametersBuilder)) {
+ try (FilteredWalIterator stIt =
walIterator(factory.iterator(iteratorParametersBuilder), params.getPages())) {
Review comment:
We don't need to switch from abstract WALIterator interface to exact
implementation. This could be hidden in `walIterator` and
`getCurrentWalFilePath` implementations.
If pages were not provided by the user we don't need to use
FilteredWalIterator with effectively no-op filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
