timoninmaxim commented on pull request #8490:
URL: https://github.com/apache/ignite/pull/8490#issuecomment-790029287
Hi @korlov42 , @AMashenkov !
Thanks for all comments. I've fixed most of them, the biggest changes are:
1. Rework of hierarchies: IndexRow, IndexKey;
2. Hide packages from public to internal;
3. Restore backward compatibility for POJO type;
4. Replace Schema with RowHandler.
5. Introduce interfaces for date/time keys and delegates implementations to
H2 (as it contains a lot of custom H2 logic, and license of h2 does not allow
use this code, only in binary form).
For most of other comments I provide fixes, comment them and resolve issues.
Some of issues are not resolved to just clearify that my fix is correct.
The only things to finalize:
1. Cursor implementations can't be implemented other way as H2 ("select
max(col) from table" query) depends on the logic that it invokes get() before
next(). Currently I see a single way - put a comment there and fix with Calcite
integration. Or
2. MVCC tests, including C++ mvcc test, can I just remove all of them?
3. If design is OK, then I will run performance tests.
Could you please review my PR again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
