ygerzhedovich commented on a change in pull request #8855:
URL: https://github.com/apache/ignite/pull/8855#discussion_r587584832
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteTableImpl.java
##########
@@ -59,16 +62,21 @@
/** */
private final Statistic statistic;
+ /** */
+ private final GridKernalContext ctx;
+
/** */
private volatile GridH2Table tbl;
/** */
private final Map<String, IgniteIndex> indexes = new ConcurrentHashMap<>();
/**
- * @param desc Table descriptor.
+ * @param ctx Kernal context.
+ * @param desc Table descriptor.
*/
- public IgniteTableImpl(TableDescriptor desc) {
+ public IgniteTableImpl(GridKernalContext ctx, TableDescriptor desc) {
Review comment:
GridCacheProcessor and GridQueryProcessor required, not whole
KernalContext, isn't it?
I understand that it widely used practice in Ignite when we pass CTX
everywhere. However, it makes code more coupled. Most of the code will be moved
into Ignite 3.0, let's try to make it better from now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
