ptupitsyn commented on a change in pull request #8960: URL: https://github.com/apache/ignite/pull/8960#discussion_r607024859
########## File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientCacheEntryListenersRegistry.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.client.thin; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import javax.cache.configuration.CacheEntryListenerConfiguration; + +/** + * Per-cache cache entry listeners registry. Listeners can't be stored inside ClientCache instance, since there can be + * several such instances per one cache. + */ +public class ClientCacheEntryListenersRegistry { Review comment: > There is no requirement for the uniqueness of this ID Right now this ID is required to match either a compute task ID, or a continuous query ID. A combination of `resId`+`notificationCode` is required to be "unique". We can use `IgniteBiTuple` as a map key. If we are going to introduce predefined ids (like 0 or -1) for general-purpose events - that will work fine as well. > each listener can implement its own strategy for resource ID mapping This looks like code duplication to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
