NSAmelchev commented on a change in pull request #8928:
URL: https://github.com/apache/ignite/pull/8928#discussion_r607262611
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/Checkpointer.java
##########
@@ -983,4 +986,26 @@ public CheckpointProgress currentProgress() {
private boolean isShutdownNow() {
return shutdownNow;
}
+
+ /**
+ * Writes checkpoint performance statistics.
+ */
Review comment:
Lets add `@param` javadocs
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/Checkpointer.java
##########
@@ -481,6 +481,9 @@ private void doCheckpoint() {
tracker.onEnd();
if (chp.hasDelta() || destroyedPartitionsCnt > 0) {
+ if
(cacheProcessor.context().kernalContext().performanceStatistics().enabled())
+ writeStatistics(chp, tracker);
Review comment:
I think we should write all checkpoints.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PagesWriteSpeedBasedThrottle.java
##########
@@ -228,6 +228,9 @@ public PagesWriteSpeedBasedThrottle(
doPark(throttleParkTimeNs);
}
+ if (pageMemory.performanceStatistics() != null &&
pageMemory.performanceStatistics().enabled())
Review comment:
Is it can be `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
